rust: remove unused #9419
Closed
rust: remove unused #9419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Ticket: OISF#4083
catenacyber
force-pushed
the
rust-unused-v10
branch
from
67d7fe1
to
e2a0416
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9419 +/- ##
==========================================
- Coverage 82.17% 82.13% -0.05%
==========================================
Files 968 968
Lines 274198 274195 -3
==========================================
- Hits 225331 225211 -120
- Misses 48867 48984 +117
Flags with carried forward coverage won't be shown. Click here to find out more. |
jasonish
approved these changes
Aug 30, 2023
Closed
|
Information: QA ran without warnings. Pipeline 15786 |
Closed
|
Rebased in #9498 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
None, generic cleaning
https://redmine.openinfosecfoundation.org/issues/4083
Describe changes:
Found with
git grep 'pub ' rust/src/ | cut -d: -f1 | uniq | xargs sed -i -e 's/pub /pub(crate) /'then see rust warnings when compilingThere is nothing more to be done :
rrclassin DNSQueryEntry) : I feel good to keep themRebase #9256 with review taken into account